fix: Resolve async issue during F5 debugging #3900
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| // Check if local dev server is running. | ||
| try { | ||
| await axios.get(`http://${localServerUrl}`) | ||
| axios.get(`http://${localServerUrl}`) |
Contributor
There was a problem hiding this comment.
Removing await means any error from axios.get() won’t be caught by the try-catch block. If the dev server is down, the error will be unhandled. Consider attaching a .catch handler or otherwise handling promise rejections.
Collaborator
There was a problem hiding this comment.
It seems we're trying to fall back to this.getHtmlContent(webview) if your local server isn't running, but now it won't do that. What happens if your local server isn't running / fails to start? Seems like the webview will be completely broken in that case.
github-project-automation
bot
moved this from PR [Pre Approval Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Resolve async issue during F5 debugging
This PR fixes an issue that occurs when debugging the extension using F5, which was preventing the debugger from properly loading the extension.
Changes:
Technical details:
In ClineProvider.ts, axios.get already returns a Promise, so the await keyword is unnecessary. Removing await allows the request to execute asynchronously in the background without blocking the extension's initialization process, thus resolving the loading issue during F5 debugging.
Important
Removes unnecessary
awaitfromaxios.getinClineProvider.tsto fix async issue during F5 debugging, improving extension startup performance.awaitfromaxios.getcall inClineProvider.tsto fix async issue during F5 debugging.axios.getalready returns a Promise, soawaitis unnecessary and was causing blocking behavior.This description was created by
for a622b57. You can customize this summary. It will automatically update as commits are pushed.